Skip to content

fix: ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success'#50

Closed
gustaff-weldon wants to merge 3 commits intosoftprops:masterfrom
zencargo:master
Closed

fix: ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success'#50
gustaff-weldon wants to merge 3 commits intosoftprops:masterfrom
zencargo:master

Conversation

@gustaff-weldon
Copy link
Contributor

@gustaff-weldon gustaff-weldon commented Apr 21, 2023

We have encountered infinite wait issues with this plugin when for some reason some runs were marked as in_progress but also successful:

{
  "id": 4743138635,
  "name": "ci",
  "head_branch": "main",
  "head_sha": "094866bfa4cece7810af835a51f6aacbe6051654",
  "path": ".github/workflows/ci.yml",
  "run_number": 54898,
  "event": "push",
  "status": "in_progress",
  "conclusion": "success",
  "workflow_id": 3110243,
  "check_suite_id": 12339949756,
  "check_suite_node_id": "CS_kwDOBPfPnM8AAAAC34SwvA",
  "created_at": "2023-04-19T12:13:16Z",
  "updated_at": "2023-04-19T12:27:06Z",

For such weird runs, turnstyle keeps waiting forever.

This PR filters out all such cases, to prevent action from waiting for these.

@chenrui333 chenrui333 changed the title Ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success' fix: ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success' Jun 19, 2024
@chenrui333 chenrui333 added the bug Something isn't working label Jun 19, 2024
chenrui333
chenrui333 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add some tests and fix the merge conflict, thanks!

@chenrui333 chenrui333 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gustaff-weldon @chenrui333